Promote internal _Countl_zero to __msvc_bit_utils.hpp to reduce code duplication and improve consistency - #5696
Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits intoSep 10, 2025
Conversation
Alex Guteniev (AlexGuteniev)
changed the title
_Countl_zero to __msvc_bit_utils.hpp
Stephan T. Lavavej (StephanTLavavej)
added
the
enhancement
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Aug 28, 2025
Member
|
Thanks, this is great! I love the reduction of code duplication. 😻 😻 |
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Ready To Merge
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed |
Member
|
I've fixed a stealth merge conflict with #5637. |
Stephan T. Lavavej (StephanTLavavej)
merged commit Sep 10, 2025
d08317c
into
microsoft:main
39 checks passed
Member
|
Alex Guteniev (@AlexGuteniev), he's my hero, gonna take code duplication down to zero! 🦸♂️ 🌍 😹 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes to improve consistency:
_Countl_zero_internalto just_Countl_zero, consistently with_Countr_zeroand_Popcount.__msvc_int128.hppto__msvc_bit_utils.hpp, where_Countr_zeroand_Popcountalready are_STDincountl_one, whuch also increases consistency.