Optimize _Div_ceil<_Signed128> - #5637
Merged
Stephan T. Lavavej (StephanTLavavej) merged 14 commits intoSep 10, 2025
Merged
Conversation
Jakub Mazurkiewicz (JMazurkiewicz)
requested a review
from a team
as a code owner
July 2, 2025 11:09
…d[1])` statement
… `_Div_ceil`? Use `_ZERO_OR_NO_INIT` for downlevel support.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Sep 5, 2025
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Ready To Merge
in STL Code Reviews
Member
|
Thanks! 😻 I pushed a few simplifications/optimizations, please double-check. |
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed |
Stephan T. Lavavej (StephanTLavavej)
merged commit Sep 10, 2025
1a11f5d
into
microsoft:main
39 checks passed
Member
|
Thanks for mathing faster! 🧮 🚀 😻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_Sizetemplate parameter to_Int._Signed128::_Div_ceilfunction, which is simply a combination of_Base128::_Divideand_Base128::_Modulo. For better performance, this function does not accept negative arguments.<ranges>:_Div_ceilcan be implemented more efficiently for_Signed128and_Unsigned128#2948.