Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't pass destroyed TextEditors to find-and-replace #2105
Merged
Conversation
smashwilson
added this to In progress
in Sprint : 4 April 2019 - 8 May 2019 : v0.29.0
via automation
codecov
bot
commented
Apr 29, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #2105 +/- ##
==========================================
+ Coverage 92.55% 92.55% +<.01%
==========================================
Files 207 207
Lines 12021 12025 +4
Branches 1746 1754 +8
==========================================
+ Hits 11126 11130 +4
Misses 895 895
Continue to review full report at Codecov.
|
|
Nice fix and cleanup |
Sprint : 4 April 2019 - 8 May 2019 : v0.29.0
automation
moved this from In progress
to Merged
Apr 30, 2019
smashwilson
added a commit
that referenced
this pull request
May 8, 2019
Don't pass destroyed TextEditors to find-and-replace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
smashwilson commentedApr 29, 2019
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
Within items that embed TextEditors (
ChangedFileItem,CommitDetailItem,CommitPreviewItem, andIssueishDetailItem), avoid triggering theobserveEmbeddedTextEditorcallback used by find-and-replace with TextEditors that have already been destroyed.Screenshot
N/A
Alternate Designs
N/A
Benefits
Fixes a stack trace.
Possible Drawbacks
N/A
Applicable Issues
Fixes #2073.
Metrics
N/A
Tests
Augmented existing test suite to cover destroyed-editor cases.
Documentation
N/A
Release Notes
N/A
User Experience Research (Optional)
N/A