Skip to content

Fix plistPath when using a prebuilt binary (appPath) - #2705

Merged
thymikee merged 2 commits into
react-native-community:mainfrom
jenskuhrjorgensen:fix/plist-path-with-prebuilt-binary
Oct 1, 2025
Merged

Fix plistPath when using a prebuilt binary (appPath)#2705
thymikee merged 2 commits into
react-native-community:mainfrom
jenskuhrjorgensen:fix/plist-path-with-prebuilt-binary

Conversation

@jenskuhrjorgensen

@jenskuhrjorgensen jenskuhrjorgensen commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

Summary

Fix plist path in installApp when running with a prebuilt binary (when appPath is set) located at a custom path.

As discussed with @thymikee here:
#2517 (comment)

See more discussion with @thymikee here:
#2517 (comment)

Test Plan

Unfortunately, there are no tests for the --binary-path option (which is probably also why this feature broke at some point), but I see it as out of scope for this PR to correct that, so testing will have to be done manually by running

npx react-native run-ios --binary-path ./myBinary.app --scheme '<SCHEME_USED_TO_BUILD_APP>'

With a prebuilt binary and validate that it actually installs and launches the app.

Checklist

  • Documentation is up to date.
  • Follows commit message convention described in CONTRIBUTING.md.
  • For functional changes, my test plan has linked these CLI changes into a local react-native checkout (instructions).
@jenskuhrjorgensen

jenskuhrjorgensen commented Oct 1, 2025

Copy link
Copy Markdown
Contributor Author

Hi @thymikee
Is there a chance you will pick this up soon? 🙏 Or are you awaiting something from me?

@thymikee thymikee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thymikee
thymikee merged commit 3087830 into react-native-community:main Oct 1, 2025
4 of 8 checks passed
@jenskuhrjorgensen

Copy link
Copy Markdown
Contributor Author

Hi @thymikee
Is there a chance that we can get a new release of the @react-native-community/cli-platform-ios package to contain this fix and some other merged PRs so we can get rid of some npm patches? 🙏

@jenskuhrjorgensen

Copy link
Copy Markdown
Contributor Author

Hi @thymikee
Is there any chance that we can soon get a new release of this lib to contain all the great improvement that have been merged since October? 🙏

@thymikee

thymikee commented Jan 7, 2026

Copy link
Copy Markdown
Member

@jenskuhrjorgensen published 20.1.0, long overdue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants