feat: support private mirrors - #1240
Conversation
|
the failures dont seem related to this change are they? |
|
Hello @marco-ippolito, Thank you for your pull request! We are currently reviewing it. To resolve the check failures, could you please rebase your branch with the main branch and push the changes. |
|
@aparnajyothi-y thanks, rebased |
commented
Mar 27, 2025
commented
Mar 27, 2025
|
@aparnajyothi-y change the message to |
248ba43 to
40509ec
Compare
commented
Mar 28, 2025
|
I wonder if we can merge this |
commented
Mar 28, 2025
|
Hello @marco-ippolito, With the latest commit, the log message now correctly displays the mirror URL when provided, which is the expected behavior. However, in the default fallback scenario (when no mirror URL is provided), the log message currently shows: "Falling back to download directly from." Instead, it should remain as it was previously, showing: "Falling back to download directly from Node." |
commented
Mar 31, 2025
|
@aparnajyothi-y thanks I have updated the code |
commented
Apr 1, 2025
|
Hello @marco-ippolito, With the latest commit, the log message still showing: "Falling back to download directly from" Instead, it should remain as it was previously, showing: "Falling back to download directly from Node" |
commented
Apr 1, 2025
|
@aparnajyothi-y amended |



Fixes: #1150
Fixes: #730