v6 updates - #210
Merged
Merged
Conversation
smaeda-ks
commented
Sep 15, 2019
| # set default values | ||
| job_ids = opts.fetch(:job_ids, nil) | ||
| params = {} | ||
| params[:job_ids] = Array.wrap(job_ids).join(',') if job_ids |
Contributor
Author
There was a problem hiding this comment.
bug: Array#wrap is only available for ActiveSupport in Rails. This was introduced in b1f2e97#diff-697bfc02b2bb3faa338ddbb781e0fb93 (2017)
smaeda-ks
force-pushed
the
smaeda-ks/develop/v6
branch
from
September 15, 2019 21:54
d6a2142 to
d605858
Compare
smaeda-ks
requested review from
jbabichjapan,
juanshishido,
osowskit and
tushdante
September 15, 2019 23:10
tushdante
approved these changes
Sep 16, 2019
tushdante
left a comment
tushdante
left a comment
Contributor
There was a problem hiding this comment.
Minor changes, but otherwise 👍
smaeda-ks
force-pushed
the
smaeda-ks/develop/v6
branch
from
September 18, 2019 20:10
195cd85 to
8f867df
Compare
tushdante
approved these changes
Sep 18, 2019
tushdante
left a comment
tushdante
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM! Just wanted to get your thoughts on the active entities question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://twittercommunity.com/t/ads-api-version-6/129060