Skip to content

PHP 8.2 Deprecation: Fix creation of dynamic property.#193

Merged
danielbachhuber merged 1 commit intowp-cli:mainfrom
Soean:php-warning-fix
Jan 9, 2024
Merged

PHP 8.2 Deprecation: Fix creation of dynamic property.#193
danielbachhuber merged 1 commit intowp-cli:mainfrom
Soean:php-warning-fix

Conversation

@Soean
Copy link
Copy Markdown
Contributor

@Soean Soean commented Jan 8, 2024

If I use the search-replace command wp search-replace 'aaa' 'bbb' wp_users --format=table --verbose --dry-run with WP CLI 2.9.0 and PHP 8.2.14, I get the warning:

Deprecated: Creation of dynamic property Search_Replace_Command::$start_time is deprecated in /vendor/wp-cli/search-replace-command/src/Search_Replace_Command.php on line 381

This PR fixes the warning.

@Soean Soean requested a review from a team as a code owner January 8, 2024 12:55
@danielbachhuber danielbachhuber added this to the 2.1.5 milestone Jan 9, 2024
@danielbachhuber danielbachhuber added the command:search-replace Related to 'search-replace' command label Jan 9, 2024
@danielbachhuber danielbachhuber merged commit f6c828a into wp-cli:main Jan 9, 2024
@Soean Soean deleted the php-warning-fix branch January 9, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:search-replace Related to 'search-replace' command

3 participants