Remove email-campaign skill (superseded by tdx-skills:engage) - #206
Remove email-campaign skill (superseded by tdx-skills:engage)#206LorenzoCadiz wants to merge 1 commit into
Conversation
The email-campaign skill duplicated tdx-skills:engage's scope while using a non-standard mechanism that broke HTML rendering in Treasure AI Studio. Root cause: email-campaign wrote raw HTML to /tmp and pushed it via a hypothetical `engage_email_builder` TD Workflow, passing html_content as a shell param. With no YAML wrapper there is no `editor_type` and no `variables` block. It also instructed Claude to target BeeFree-compatible HTML, but the beefree editor uses a proprietary JSON format that cannot be generated from HTML at all — engage mandates `editor_type: grapesjs` for exactly this reason. So the skill steered toward the one editor type guaranteed not to render hand-authored HTML. tdx-skills:engage already covers this surface correctly via YAML+HTML and native `tdx engage template/campaign push`, and its description explicitly claims the "create an email" / "build an HTML email" phrasings. - Delete email-campaign-skills/ (4 files) - Drop the email-campaign-skills plugin block from marketplace.json - Retarget the existing trigger test to `engage` and add one covering the raw-HTML phrasing No changes to tdx-skills/engage — nothing from the removed skill was merged into it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Hey @LorenzoCadiz — quick note before this merges. The deleted references/email-design-patterns.md had solid content (table-based layout, inline CSS rules, Outlook quirks, CTA button patterns) that doesn't exist anywhere in tdx-skills:engage. Since you already have it in the diff, would you be open to opening a follow-up PR to add it as a reference file inside tdx-skills/engage/references/? No urgency on blocking this PR — just want to make sure that knowledge doesn't disappear. Thanks for the cleanup work here 🙌 And if you think it is not necessary then, no need to do it |
|
@LorenzoCadiz quick governance flag. tdx-skills/engage is one of our Default On skills but its SKILL.md is missing the required Tier 1 fields: owner, tier, classification, and phase. It also has no test.yml or SKILL.meta.yml. This is the same checklist we applied to segment in PR #196. Can whoever owns this skill open a small PR to add those fields? Happy to review — just want to make sure our Default On skills are all fully governed. Thanks! |
adher-code
left a comment
There was a problem hiding this comment.
Apporved! Thanks for the clean up! I left two comments that are not blockers but I think good to have.
Summary
Removes the
email-campaignskill. It duplicatedtdx-skills:engage's scope while using a non-standard mechanism that broke HTML rendering in Treasure AI Studio.Root cause
email-campaignwrote raw HTML to/tmp/email_campaign_preview.htmland pushed it through aengage_email_builderTD Workflow, passing the markup as a shell param:tdx wf run engage_email_builder --param html_content="$(cat /tmp/email_campaign_preview.html)"With no YAML wrapper there is no
editor_typeand novariablesblock — the two things Engage needs to render and personalize a template.It gets worse: line 93 of the old SKILL.md told Claude to generate BeeFree-compatible HTML. Per
tdx-skills/engage/SKILL.md:82, thebeefreeeditor uses a proprietary JSON format that cannot be generated from HTML, which is whyengagemandateseditor_type: grapesjs. The skill was steering toward the one editor type guaranteed not to render hand-authored HTML — so the bug was not fixable by bolting YAML onto it.Its integration reference also depended on a workflow that "hasn't been deployed to this account yet," with a manual copy-paste fallback. That whole path is superseded by native
tdx engage template push.Why
engagefully covers itemail-campaign(removed)tdx-skills:engage/tmptype: template/campaign) + HTMLpreview_document(generic)preview_engage_template/preview_engage_campaigntdx wf run engage_email_buildertdx engage template push <yaml> --yeseditor_typegrapesjs(required)engage's description already claims the overlapping phrasings — "even if the user only mentions 'create an email' or 'build an HTML email'".Changes
email-campaign-skills/(4 files, 560 lines)email-campaign-skillsplugin block frommarketplace.json(14 plugins remain)engage; add one covering the raw-HTML phrasingNo changes to
tdx-skills/engage— nothing from the removed skill was merged into it.Verification
marketplace.jsonparses; all 14 plugins' skill paths resolve to real dirs with aSKILL.md, all./-prefixedextract-skills.shruns clean — 87 skills,email-campaignno longer among themengage:engageengageengageThe full ~150-test suite was not run — only the three tests this change touches.
Note for reviewers
engagegives no HTML authoring guidance (table layout, inline CSS, Outlook quirks). Claude generally knows these conventions, so this is likely fine, but it's the first place to look if rendering issues persist. Not addressed here to keep the change scoped to the removal.🤖 Generated with Claude Code