Fix Quickstart docs: compare form data with .json() not .text - #7224
Closed
thakoreh wants to merge 1 commit into
Closed
Fix Quickstart docs: compare form data with .json() not .text#7224thakoreh wants to merge 1 commit into
thakoreh wants to merge 1 commit into
Conversation
The httpbin.org response includes a dynamic X-Amzn-Trace-Id header which makes r1.text == r2.text return False even when the form data is identical. Changed the comparison to use .json()['form'] which correctly compares only the form data. Fixes: psf#6949
nateprewitt
force-pushed
the
fix-quickstart-docs-comparison
branch
from
March 3, 2026 19:07
dfc6910 to
438c71a
Compare
Member
|
Resolving as duplicate of #6960. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6949
Problem
The Quickstart documentation shows that r1.text == r2.text returns True when comparing two POST requests with the same form data. However, httpbin.org responses include a dynamic X-Amzn-Trace-Id header which makes this comparison return False.
Solution
Changed the comparison to use .json()['form'] which correctly compares only the form data.