Skip to content

Add PHP History Timeline#1284

Open
mkurzeja wants to merge 14 commits intophp:masterfrom
accesto:master
Open

Add PHP History Timeline#1284
mkurzeja wants to merge 14 commits intophp:masterfrom
accesto:master

Conversation

@mkurzeja
Copy link
Copy Markdown

Initial implementation of #1265

This adds two main changes:

  1. New view of PHP History Timeline as a separate page. Events are loaded from a .json file

image

https://drop.accesto.com/v/f0cATp

  1. Adds link to the new page to the right side menu:
    image

Events from years 2020-2025 are not included in this PR, I will create a separate one.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 23, 2025

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 23, 2025

🚀 Preview for commit 187070c can be found at https://web-php-pr-1284.preview.thephp.foundation

@saundefined
Copy link
Copy Markdown
Member

Looks great, thanks!

Please note Sara's comment (I suppose we can wait for others to weigh in as well).

IMO: I don't see a problem with web-php review for changes like this, as it's no more work than user conference review, but I'd be happy to hear from others.

@mkurzeja
Copy link
Copy Markdown
Author

Thanks, I get the point with the wiki idea, I just struggle a bit with some flows around it. Will summarize everything and reply to the comment directly.

Something strange happened with the visual regression test. Screen was updated, yet if failed again. I will check this again.

@mkurzeja
Copy link
Copy Markdown
Author

@saundefined we are now working on running the visual tests locally, so we can check why it fails.

@saundefined
Copy link
Copy Markdown
Member

@mkurzeja the last visual test looks awesome! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment