Bug 2065136 - SVG text shouldn't allow generated content. - #342
Closed
emilio wants to merge 1 commit into
Closed
Conversation
Restores pre-regression and interoperable behavior.
Contributor
|
View this pull request in Lando to land it once approved. |
dshin-moz
reviewed
Aug 20, 2026
| @@ -4815,7 +4815,8 @@ nsCSSFrameConstructor::FindSVGData(const Element& aElement, | |||
| SIMPLE_SVG_CREATE(defs, NS_NewSVGContainerFrame), | |||
| {nsGkAtoms::text, | |||
| {NS_NewSVGTextFrame, | |||
| FCDATA_DISALLOW_OUT_OF_FLOW | FCDATA_ALLOW_BLOCK_STYLES, | |||
| FCDATA_DISALLOW_OUT_OF_FLOW | FCDATA_ALLOW_BLOCK_STYLES | | |||
| FCDATA_DISALLOW_GENERATED_CONTENT, | |||
Contributor
There was a problem hiding this comment.
(Ah, I guess it wasn't needed before because NAC was broadly disallowed prior to bug 1850539
dshin-moz
approved these changes
Aug 20, 2026
lando-worker Bot
pushed a commit
that referenced
this pull request
Aug 21, 2026
Restores pre-regression and interoperable behavior. Pull request: #342
|
Pull request closed by commit b953757 |
lando-worker Bot
pushed a commit
that referenced
this pull request
Aug 21, 2026
Restores pre-regression and interoperable behavior. Pull request: #342 Differential Revision: https://phabricator.services.mozilla.com/D320383
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 21, 2026
Restores pre-regression and interoperable behavior. Pull request: mozilla-firefox/firefox#342 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2065136 gecko-commit: eb12e80b6c5cd8340aa47bf40131e062bb95907f gecko-commit-git: b9537570d78577ed7f170bd85395c1034bb5ec76 gecko-reviewers: dshin
lando-worker Bot
pushed a commit
that referenced
this pull request
Aug 23, 2026
…ONTBUILD Restores pre-regression and interoperable behavior. Pull request: #342 Differential Revision: https://phabricator.services.mozilla.com/D320384
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores pre-regression and interoperable behavior.