Bug 2064471 - Make -moz-appearance a legacy shorthand of appearance. r#style - #337
Closed
emilio wants to merge 1 commit into
Closed
Bug 2064471 - Make -moz-appearance a legacy shorthand of appearance. r#style#337emilio wants to merge 1 commit into
emilio wants to merge 1 commit into
Conversation
Contributor
|
Warning The base branch is currently set to |
Contributor
|
View this pull request in Lando to land it once approved. |
dshin-moz
reviewed
Aug 18, 2026
| @@ -242,13 +242,11 @@ spec = "https://drafts.fxtf.org/motion-1/#offset-shorthand" | |||
|
|
|||
| [-webkit-perspective] | |||
| sub_properties = ["perspective"] | |||
| derive_serialize = true | |||
Contributor
There was a problem hiding this comment.
So it seems that we can't have "IS_LEGACY_SHORTHAND" + derive_serialize = true anymore? Worth commenting that?
Contributor
Author
There was a problem hiding this comment.
I guess we could and instead deal with it on the expansion instead of expecting to_css_legacy. I actually like that a bit more.
dshin-moz
approved these changes
Aug 18, 2026
dshin-moz
left a comment
dshin-moz
left a comment
Contributor
There was a problem hiding this comment.
Seems we're skipping what feels like a superfluous derive and expecting parse_legacy and such. Nice.
Don't restrict values for now.
emilio
force-pushed
the
make-appearance-legacy
branch
from
August 21, 2026 18:45
e05a0fd to
8ef490c
Compare
Contributor
Author
|
Rebased + fixed the property exposure / |
|
Pull request closed by commit 42345bb |
lando-worker Bot
pushed a commit
that referenced
this pull request
Aug 21, 2026
…r#style r=dshin Don't restrict values for now. Pull request: #337
github-actions Bot
pushed a commit
to DioxusLabs/stylo
that referenced
this pull request
Aug 22, 2026
…r#style r=dshin Don't restrict values for now. Pull request: mozilla-firefox/firefox#337
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't restrict values for now.