feat(analytics): Implement semver and date custom ops for flags runtime props - #171
Conversation
Confidence Score: 4/5The PR is not yet safe to merge because negative fractional epoch-millisecond targets can mis-evaluate pre-1970 date rules. The previously reported rounding mismatch remains: RFC3339 conversion and negative millisecond conversion round equivalent instants in opposite directions. Files Needing Attention: lib/mixpanel-ruby/flags/custom_operators.rb
|
| Filename | Overview |
|---|---|
| lib/mixpanel-ruby/flags/custom_operators.rb | Implements custom date and SemVer comparisons; negative fractional epoch milliseconds remain inconsistent with equivalent RFC3339 instants. |
| lib/mixpanel-ruby/flags/local_flags_provider.rb | Registers the custom operators and requires runtime rules to return Boolean true. |
| mixpanel-ruby.gemspec | Updates the JSONLogic runtime dependency to the 0.2 release line. |
Reviews (3): Last reviewed commit: "updating tests and adding semver limits" | Re-trigger Greptile
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #171 +/- ##
==========================================
+ Coverage 97.16% 97.28% +0.12%
==========================================
Files 15 16 +1
Lines 775 885 +110
==========================================
+ Hits 753 861 +108
- Misses 22 24 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Adds Semantic Versioning and RFC3339 date comparison support for feature flags runtime event matching. This implements them as extensions to the JSONLogic library that is being used for targeting.
See here for more information about the comparators and golden vector list