Make expo-crypto an optional dependency - #292
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes the expo-crypto dependency optional to address issue #291 by shifting its management in package.json and adjusting the device ID generation logic accordingly.
- Moves expo-crypto from mandatory to optionalDependencies in package.json.
- Modifies mixpanel-persistent.js to dynamically require expo-crypto with a fallback to uuid.v4() when generating a device ID.
- Removes .vscode/settings.json.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Moves expo-crypto into the optionalDependencies block. |
| javascript/mixpanel-persistent.js | Changes device ID generation to use expo-crypto if available, with fallback. |
| .vscode/settings.json | Removes VSCode settings; confirm if this is an intentional cleanup. |
|
Leaving this here in case this helps anyone else. On react-native 0.76 and expo 52 I got the following error, solved by downgrading to mixpanel-react-native@3.0.9 to avoid the expo-crypto module. |
Collaborator
Author
|
@sseppola |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #291