Skip to content

Allow to pass MPConfig to MixPanelAPI.getInstance() and deprecate the wrapping methods MixPanelAPI #829

Description

@juliocbcotta

Hello there, as we migrated to MixPanel 7.4.0, I found some issues in our code.
For instance, the serverURL that we would set in the MPConfig were not being used in the library. We were able to solve this by using the MixPanelAPI wrapping methods t o access the currently used MPConfig, but not without some pain for our devs (We used MPCofing.getInstance to set the serverURL and it was hard to detect the issue) and product folks (we lost weeks of data).

I would like to recommend allowing passing a MPConfig instance to MixPanelAPI.getInstance and deprecating the methods from MixPanelAPI that just do the forwarding to the internal instance. This would expose only one proper way of setting MPConfig values.

Thank you.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions