Skip to content

Value Metric Updates - #181

Open
mbocianski wants to merge 2 commits into
mainfrom
mb-experiments-8-18-26
Open

Value Metric Updates#181
mbocianski wants to merge 2 commits into
mainfrom
mb-experiments-8-18-26

Conversation

@mbocianski

@mbocianski mbocianski commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

See Slack thread for details.

https://mixpanel.slack.com/archives/C0547DQTVCN/p1786744670689369

Mintlify

0 threads from 0 users in Mintlify

  • No unresolved comments

Review in Mintlify

- Updated docs/experiments.mdx

Mintlify-Source: dashboard-editor
@greptile-apps

greptile-apps Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

The PR is not ready to merge because the Value Metric denominator guidance remains internally contradictory.

The page simultaneously says lift and group-identifier calculations always normalize by exposures while the revised Value Metric section says group rates and variance use only users with observed values.

Files Needing Attention: docs/experiments.mdx

Important Files Changed

Filename Overview
docs/experiments.mdx Updates Value Metric denominator guidance, but the general lift and group-identifier notes still contradict the new exception.

Reviews (2): Last reviewed commit: "Merge branch 'main' into mb-experiments-..." | Re-trigger Greptile

Comment thread docs/experiments.mdx
Comment thread docs/experiments.mdx
| ------------ | ---------------- |
| Small (< 100k) | 50-100% |

| **MTU bucket** | \*\*Estimated MEU (% MTU) \*\* |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Escaped table heading emphasis

The escaped asterisks render as literal ** characters rather than bolding the second heading, leaving the MEU table header visibly inconsistent with the first column.

Suggested change
| **MTU bucket** | \*\*Estimated MEU (% MTU) \*\* |
| **MTU bucket** | **Estimated MEU (% MTU)** |

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment thread docs/experiments.mdx
- **Variance:** Calculated using Bernoulli distribution: p × (1-p)
- **Example:** If 25 out of 100 exposed users convert, group rate = 0.25 (25%). Note that this denominator is exposures — not funnel entrants. This is different from the funnel conversion rate you see in the Totals or Chart tabs, which uses funnel entrants as the denominator.

**Value Metrics (Averages, Sums):**

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Value Metrics section is clearer, but could we add one short sentence defining what counts as an “observed value”? Readers may not know whether that means only users who triggered the underlying event, and it would help to explicitly say how missing or zero values are handled.

Comment thread docs/experiments.mdx
- **Variance:** Calculated from the distribution of individual property values, over that same observed-value population
- **Example:** If the treatment group spent \$5,000 total from 20 users who had a value (out of 100 exposed), the group rate = \$250 average per user with an observed value

**Why This Matters:** Value metrics report the average based only on users who had an observed value for the metric, not all exposed users, since there's no natural zero for someone who never triggered the underlying event. The exposed count still matters; it's used downstream in the standard error and confidence interval calculation, so overall reach still factors into how confident you can be in the result, just not into the group rate or variance themselves.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a helpful clarification, but it may still read as if exposures are no longer part of the Value Metrics calculation at all. Could we make the distinction explicit that exposures are excluded from the group rate/variance, but still used in downstream standard error and confidence interval calculations?

Comment thread docs/experiments.mdx

Lift is the percentage difference between the control and variant(s) metrics.
$Lift= { (variant \,group\,rate - control \,group\,rate) \over (control \,group\,rate)}$
Lift is the percentage difference between the control and variant(s) metrics. $$Lift= { (variant \,group\,rate - control \,group\,rate) \over (control \,group\,rate)}$$

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lift explanation is more explicit now, but the formula and the metric-type-specific denominator rules are spread across several paragraphs. Could we consolidate this a bit so readers don’t miss that lift behaves differently depending on the metric type?

Comment thread docs/experiments.mdx
@@ -384,9 +385,10 @@ Benjamini-Hochberg controls the **false discovery rate**, the share of your flag
This correction operates on the values in your breakdown, which is a different axis from the [Multiple Testing Correction](#bonferroni-correction) you apply across metrics and variants. That means adding more breakdown values doesn't inflate your false positive rate.

### When do we say the Experiment is ready to review?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“Experiment is ready to review” could be interpreted as statistically ready, not just setup-complete. Could we clarify that this banner reflects configuration completion rather than a recommendation to end the experiment?

@myronkaifung myronkaifung left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good formatting wise. @mbocianski feel free to merge after reviewing Elliot's comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants