fix(SUPP-148): Fix broken Event Approval link in Data Clean-Up - #11
Merged
Conversation
SUPP-148 Bug: Broken Hyperlink in Data Clean-Up
Type: Bug · Fix before launch: Yes · Reporter: Cara Cheng Bug summary URL Screenshots/videos Migrated from Notion · source entry |
Contributor
Confidence Score: 5/5Safe to merge — single-line docs link fix targeting a confirmed existing page. The change replaces a dead changelog URL with a valid docs path that resolves to an existing file ( No files require special attention.
|
| Filename | Overview |
|---|---|
| docs/data-governance/data-clean-up.mdx | Single-line fix replacing a broken changelog link with the correct docs page for Event Approval, which exists at the new path. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["Data Clean-Up page\n/docs/data-governance/data-clean-up"] -->|"Other Resources link (before)"| B["❌ 404\n/changelogs/2023-06-01-event-approval"]
A -->|"Other Resources link (after)"| C["✅ Event Approval docs\n/docs/data-governance/event-approval"]
Reviews (2): Last reviewed commit: "Merge branch 'main' into copilot/supp-14..." | Re-trigger Greptile
myronkaifung
approved these changes
Jun 9, 2026
myronkaifung
marked this pull request as ready for review
June 9, 2026 21:29
myronkaifung
requested review from
Tofufu and
myronkaifung
and removed request for
a team and
Tofufu
June 9, 2026 21:29
myronkaifung
approved these changes
Jun 9, 2026
myronkaifung
enabled auto-merge (squash)
June 9, 2026 21:30
myronkaifung
disabled auto-merge
June 9, 2026 21:45
tylergoerzen-mxp
added a commit
that referenced
this pull request
Aug 20, 2026
Completes rec #20 Part B's gate list. - New check_openapi.py: parses all 14 specs, requires openapi/info/paths, and resolves every local $ref. Uses openapi-spec-validator for full schema validation when installed, and still runs structurally without it. Passes on all 14 specs today; rejects a spec with a dangling $ref. - check_frontmatter.py now requires a non-empty description and fails on duplicate rendered titles, which rec #11 asked for. - Pin actions/checkout and actions/setup-python to commit SHAs, matching stale.yml. Collapse four near-identical jobs into one with ordered steps, and add a concurrency group. MERGE ORDER: the frontmatter gate is red until #172 (description backfill) and #178 (title dedupe) land. Verified against the #172 tree: all description errors clear, leaving only the duplicate titles that #178 resolves. Merge this last, as the plan intends. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
tylergoerzen-mxp
added a commit
that referenced
this pull request
Aug 20, 2026
Rec #11 asks for a CI uniqueness test on rendered titles, which only passes at zero duplicates. Three pairs survived the first pass: - Data Pipeline Integrations: the old-pipelines copy is now marked (Legacy), keeping "Integrations" as its sidebar label - Lookup Tables: the reference page is the API, so it becomes Lookup Tables API - Mixpanel Headless: the guide gets the benefit-style title, leaving the bare product name to the docs page Verified zero duplicate titles across the tree, so the frontmatter gate in #180 can enforce uniqueness once this and #172 land. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Event Approval" link in the Other resources section of the Data Clean-Up page pointed to a changelog entry (
/changelogs/2023-06-01-event-approval) that returns 404.Changes
docs/data-governance/data-clean-up.mdx— Updated broken link to point to the correct documentation page:Original prompt