[matroska] Update to 1.7.2 - #53669
Conversation
Billy O'Neal (BillyONeal)
left a comment
There was a problem hiding this comment.
GPT 5.6 Sol reports:
- On Windows, upstream 1.7.2 forces
BUILD_SHARED_LIBSoff even when vcpkg requests a dynamic build. Consequently,x64-windowslosesbin/matroska.dllanddebug/bin/matroska.dll, butBUILD_INFOstill reportsLibraryLinkage: dynamic.
Steve Lhomme (@robUx4) Is this expected? It looks like DLLs on Windows used to work.
| "dependencies": [ | ||
| { | ||
| "name": "ebml", | ||
| "version>=": "1.4.4" |
There was a problem hiding this comment.
Why was this version constraint dropped?
There was a problem hiding this comment.
Basically this was incorrect, as only 1.4.3 is required
Since we don't do that with other ports either: Why with this port? And why is there only version>= and not also version== (that would make sense for Boost, for example, since vcpkg doesn't rebuild things there if, say, Boost 1.81 is partially installed, but later you install something that requires a different Boost component, and vcpkg now contains Boost 1.82, the build fails because Boost checks its dependencies using EXACT).
| "version": "1.7.2", | ||
| "description": "a C++ library to parse Matroska files (.mkv and .mka)", | ||
| "homepage": "https://github.com/Matroska-Org/libmatroska", | ||
| "dependencies": [ |
There was a problem hiding this comment.
- The pre-existing manifest has no SPDX
licensefield. The installed headers state LGPL 2.1 or later, so"license": "LGPL-2.1-or-later"would describe the packaged content.
An explicit |
Steve Lhomme (@robUx4) I think the bit that tries to make it a dependent option is causing vcpkg's setting of it to be ignored. This isn't looking at commit titles, it actually tried |
|
Indeed, I just added a similar target to our CI and I see the same thing. It's fixed now but it's not in a release yet. You may pick Matroska-Org/libmatroska@9d2029c to get the DLL. The same problem exists in libebml. |
c292c5a to
b259df5
Compare
b259df5 to
4a084dc
Compare
./vcpkg x-add-version --alland committing the result.