[Automated] Update Azure VM Sizes - #18725
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 18725Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 18725" |
This comment has been minimized.
This comment has been minimized.
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
499e4f0 to
27f8707
Compare
2342d5d to
a0b678e
Compare
a0b678e to
8ce79c2
Compare
This comment has been minimized.
This comment has been minimized.
8ce79c2 to
df765df
Compare
| public const string StandardDC96esV6 = "Standard_DC96es_v6"; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// VM sizes in the standardDCSv2Family. | ||
| /// </summary> | ||
| public static class StandardDCSv2 | ||
| { | ||
| /// <summary> | ||
| /// Standard_DC2s_v2 — 2 vCPUs — 8 GB RAM — Premium SSD | ||
| /// </summary> | ||
| [AspireValue("AksNodeVmSizes")] | ||
| public const string StandardDC2sV2 = "Standard_DC2s_v2"; | ||
|
|
||
| /// <summary> | ||
| /// Standard_DC4s_v2 — 4 vCPUs — 16 GB RAM — Premium SSD | ||
| /// </summary> | ||
| [AspireValue("AksNodeVmSizes")] | ||
| public const string StandardDC4sV2 = "Standard_DC4s_v2"; | ||
|
|
||
| /// <summary> | ||
| /// Standard_DC8_v2 — 8 vCPUs — 32 GB RAM — Premium SSD | ||
| /// </summary> | ||
| [AspireValue("AksNodeVmSizes")] | ||
| public const string StandardDC8V2 = "Standard_DC8_v2"; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// VM sizes in the standardDCSv3Family. | ||
| /// </summary> |
| public const string StandardDC96esV6 = "Standard_DC96es_v6"; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// VM sizes in the standardDCSv2Family. | ||
| /// </summary> | ||
| public static class StandardDCSv2 | ||
| { | ||
| /// <summary> | ||
| /// Standard_DC2s_v2 — 2 vCPUs — 8 GB RAM — Premium SSD | ||
| /// </summary> | ||
| [AspireValue("AksNodeVmSizes")] | ||
| public const string StandardDC2sV2 = "Standard_DC2s_v2"; | ||
|
|
||
| /// <summary> | ||
| /// Standard_DC4s_v2 — 4 vCPUs — 16 GB RAM — Premium SSD | ||
| /// </summary> | ||
| [AspireValue("AksNodeVmSizes")] | ||
| public const string StandardDC4sV2 = "Standard_DC4s_v2"; | ||
|
|
||
| /// <summary> | ||
| /// Standard_DC8_v2 — 8 vCPUs — 32 GB RAM — Premium SSD | ||
| /// </summary> | ||
| [AspireValue("AksNodeVmSizes")] | ||
| public const string StandardDC8V2 = "Standard_DC8_v2"; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// VM sizes in the standardDCSv3Family. | ||
| /// </summary> |
df765df to
2138344
Compare
| public const string StandardDC96esV6 = "Standard_DC96es_v6"; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// VM sizes in the standardDCSv2Family. | ||
| /// </summary> | ||
| public static class StandardDCSv2 | ||
| { | ||
| /// <summary> | ||
| /// Standard_DC2s_v2 — 2 vCPUs — 8 GB RAM — Premium SSD | ||
| /// </summary> | ||
| [AspireValue("AksNodeVmSizes")] | ||
| public const string StandardDC2sV2 = "Standard_DC2s_v2"; | ||
|
|
||
| /// <summary> | ||
| /// Standard_DC4s_v2 — 4 vCPUs — 16 GB RAM — Premium SSD | ||
| /// </summary> | ||
| [AspireValue("AksNodeVmSizes")] | ||
| public const string StandardDC4sV2 = "Standard_DC4s_v2"; | ||
|
|
||
| /// <summary> | ||
| /// Standard_DC8_v2 — 8 vCPUs — 32 GB RAM — Premium SSD | ||
| /// </summary> | ||
| [AspireValue("AksNodeVmSizes")] | ||
| public const string StandardDC8V2 = "Standard_DC8_v2"; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// VM sizes in the standardDCSv3Family. | ||
| /// </summary> |
2138344 to
167cc40
Compare
d8ff073 to
a29d1f8
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
src/Aspire.Hosting.Azure.Kubernetes/AksNodeVmSizes.Generated.cs:9910
- This is a
*.Generated.csfile; direct edits are likely to be overwritten by regeneration. If this removal is intentional, it should be made in the generator input/source (or whatever produces this file) so it remains stable across builds and future regenerations.
[AspireValue("AksNodeVmSizes")]
public const string StandardNV24adsV710V5 = "Standard_NV24ads_V710_v5";
/// <summary>
/// Standard_NV4ads_V710_v5 — 4 vCPUs — 16 GB RAM — Premium SSD
| /// <summary> | ||
| /// Standard_NV4ads_V710_v5 — 4 vCPUs — 16 GB RAM — Premium SSD | ||
| /// </summary> |
a29d1f8 to
f2ec80a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (2)
src/Aspire.Hosting.Azure.Kubernetes/AksNodeVmSizes.Generated.cs:9909
- Removing the public constant
StandardNV28admsV710V5is a breaking API change for consumers who reference it. If the SKU is being deprecated/removed, consider keeping the constant but marking it[Obsolete(...)](or providing an alias/redirect if appropriate) to preserve source compatibility, and document the removal in release notes if it must be removed.
[AspireValue("AksNodeVmSizes")]
public const string StandardNV24adsV710V5 = "Standard_NV24ads_V710_v5";
/// <summary>
/// Standard_NV4ads_V710_v5 — 4 vCPUs — 16 GB RAM — Premium SSD
/// </summary>
src/Aspire.Hosting.Azure.Kubernetes/AksNodeVmSizes.Generated.cs:9907
- This is a
*.Generated.csfile; direct edits are likely to be overwritten the next time the generator runs. If this change is intentional, apply it in the generator source/template (or the upstream data used to generate this list) so regeneration remains stable and doesn't reintroduce the removed constant.
[AspireValue("AksNodeVmSizes")]
public const string StandardNV24adsV710V5 = "Standard_NV24ads_V710_v5";
f2ec80a to
6486217
Compare
| [AspireValue("AksNodeVmSizes")] | ||
| public const string StandardNV24adsV710V5 = "Standard_NV24ads_V710_v5"; | ||
|
|
||
| /// <summary> | ||
| /// Standard_NV28adms_V710_v5 — 28 vCPUs — 160 GB RAM — Premium SSD | ||
| /// </summary> | ||
| [AspireValue("AksNodeVmSizes")] | ||
| public const string StandardNV28admsV710V5 = "Standard_NV28adms_V710_v5"; | ||
|
|
||
| /// <summary> | ||
| /// Standard_NV4ads_V710_v5 — 4 vCPUs — 16 GB RAM — Premium SSD | ||
| /// </summary> |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/Aspire.Hosting.Azure.Kubernetes/AksNodeVmSizes.Generated.cs:9909
- Removing a public constant is a breaking change for any consumers referencing
StandardNV28admsV710V5. If this SKU is being deprecated, consider keeping the constant for backward compatibility and marking it[Obsolete](optionally with a message suggesting the replacement), rather than deleting it outright. If deletion is required, it should be accompanied by a clearly documented breaking-change note (typically in release notes / changelog) and ideally coordinated with the generator source so regeneration doesn’t reintroduce it.
[AspireValue("AksNodeVmSizes")]
public const string StandardNV24adsV710V5 = "Standard_NV24ads_V710_v5";
/// <summary>
/// Standard_NV4ads_V710_v5 — 4 vCPUs — 16 GB RAM — Premium SSD
/// </summary>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/Aspire.Hosting.Azure.Kubernetes/AksNodeVmSizes.Generated.cs:9911
- This change removes the
StandardNV28admsV710V5constant from a public generated API surface. If any downstream code references it, this becomes a compile-time breaking change. If the VM size is being removed because it is invalid/deprecated, consider keeping the constant and marking it[Obsolete](optionally with an error=false message) for at least one release cycle, or provide a compatibility alias/redirect to the correct size name if it was a naming correction.
/// <summary>
/// Standard_NV4ads_V710_v5 — 4 vCPUs — 16 GB RAM — Premium SSD
/// </summary>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/Aspire.Hosting.Azure.Kubernetes/AksNodeVmSizes.Generated.cs:9911
- Removing the public constant
StandardNV28admsV710V5is a breaking change for any consumers referencing it. If the SKU is deprecated/unavailable, consider keeping the constant but marking it as obsolete (e.g.,[Obsolete]) with a message pointing to the replacement SKU, or provide an alias/redirect to the closest supported size to preserve compile-time compatibility.
[AspireValue("AksNodeVmSizes")]
public const string StandardNV24adsV710V5 = "Standard_NV24ads_V710_v5";
/// <summary>
/// Standard_NV4ads_V710_v5 — 4 vCPUs — 16 GB RAM — Premium SSD
/// </summary>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
src/Aspire.Hosting.Azure.Kubernetes/AksNodeVmSizes.Generated.cs:9907
AksNodeVmSizes.Generated.csappears to be generated output; direct edits are typically overwritten. If this change was made manually, it should instead be applied to the generator source / input data so that future regenerations preserve the removal deterministically.
public const string StandardNV24adsV710V5 = "Standard_NV24ads_V710_v5";
| [AspireValue("AksNodeVmSizes")] | ||
| public const string StandardNV28admsV710V5 = "Standard_NV28adms_V710_v5"; | ||
|
|
||
| /// <summary> |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/Aspire.Hosting.Azure.Kubernetes/AksNodeVmSizes.Generated.cs:9909
- This deletion removes a shipped public constant that is still recorded in
api/Aspire.Hosting.Azure.Kubernetes.cs:3447andapi/Aspire.Hosting.Azure.Kubernetes.ats.txt:1355, making the update source-breaking and causing API compatibility validation to fail. Keep the constant (optionally obsolete it if the SKU is no longer usable) and update the generator so transient SKU-feed changes cannot delete previously shipped members.
/// <summary>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/Aspire.Hosting.Azure.Kubernetes/AksNodeVmSizes.Generated.cs:9969
- Removing
StandardNV28admsV710V5is a source-breaking public API change; the member is still recorded in both API baselines (Aspire.Hosting.Azure.Kubernetes.cs:3447and.ats.txt:1355). A project that references this descriptor will no longer compile after updating the package. Please retain previously published descriptors (even when Azure stops returning the SKU) and update the generator to preserve them rather than deleting public constants during a scheduled refresh.
/// <summary>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/Aspire.Hosting.Azure.Kubernetes/AksNodeVmSizes.Generated.cs:9969
- Removing
StandardNV28admsV710V5is a source-breaking public API change: it remains in the shipped API baseline atsrc/Aspire.Hosting.Azure.Kubernetes/api/Aspire.Hosting.Azure.Kubernetes.cs:3447. Even if Azure no longer reports this SKU, retaining the string constant is harmless and preserves callers that compiled against it. Please keep previously shipped constants when regenerating this catalog (and update the generator so future runs cannot remove baseline APIs).
/// <summary>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/Aspire.Hosting.Azure.Kubernetes/AksNodeVmSizes.Generated.cs:9969
- This deletion removes the shipped public member
AksNodeVmSizes.StandardNVadsV710v5.StandardNV28admsV710V5, which is still tracked insrc/Aspire.Hosting.Azure.Kubernetes/api/Aspire.Hosting.Azure.Kubernetes.cs:3447. Consumers that reference it will no longer compile when rebuilt. Please retain shipped descriptors even when Azure stops returning a SKU (optionally mark it obsolete), and update the generator so later automated runs do not remove it again.
/// <summary>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/Aspire.Hosting.Azure.Kubernetes/AksNodeVmSizes.Generated.cs:9967
- Removing
StandardNV28admsV710V5breaks the shipped public and ATS API; it is still recorded inapi/Aspire.Hosting.Azure.Kubernetes.cs:3447and the ATS baseline at line 1484. Update the generator to preserve previously shipped constants (optionally marking unavailable SKUs obsolete) instead of deleting them when Azure temporarily or permanently omits a SKU, then regenerate this file.
public const string StandardNV24adsV710V5 = "Standard_NV24ads_V710_v5";
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/Aspire.Hosting.Azure.Kubernetes/AksNodeVmSizes.Generated.cs:9968
- Removing this shipped public constant is a source- and ATS-breaking change: it is still part of both
api/Aspire.Hosting.Azure.Kubernetes.cs:3447andapi/Aspire.Hosting.Azure.Kubernetes.ats.txt:1484. A transient SKU disappearance from the Azure query should not remove an existing descriptor; preserve this constant (and make the generator retain previously published entries so a later automated run does not delete it again).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/Aspire.Hosting.Azure.Kubernetes/AksNodeVmSizes.Generated.cs:9968
- Removing this shipped public constant is a breaking source/ATS API change: it is still present in both
api/Aspire.Hosting.Azure.Kubernetes.cs:3447and the ATS baseline at line 1484. Azure no longer returning a SKU should not remove its descriptor; retain previously published constants (or make the generator merge its output with the published baseline).
Auto-generated update of Azure VM size descriptors (AksNodeVmSizes.Generated.cs).