Windows ML: Consolidate ResNet projections into main solution and fix warnings - #534
Merged
Conversation
adrastogi
requested review from
Manodasan Wignarajah (manodasanW) and
Nick Eubanks (nieubank)
September 24, 2025 19:11
Nick Eubanks (nieubank)
approved these changes
Sep 24, 2025
Manodasan Wignarajah (manodasanW)
approved these changes
Sep 24, 2025
adrastogi
added a commit
that referenced
this pull request
Sep 24, 2025
… warnings (#534) * Remove Resnet C# solution and move those projects to main WinML solution * Fix warnings --------- Co-authored-by: Aditya Rastogi <adityar@ntdev.microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ResNet-related projects previously had their own solutions; we had cleaned up the one for C++ but left behind the C# one. This change removes that solution and then adds both projects to the main solution for the Windows ML area. This change also fixes a couple warnings Visual Studio flagged in the code.
Target Release
1.8.1
Checklist
Note that /azp run currently isn't working for this repo.