Improvements to WindowsML sample for MSIX packaging - #530
Merged
Conversation
Nick Eubanks (nieubank)
commented
Sep 23, 2025
Nick Eubanks (nieubank)
commented
Contributor
- Add SqueezeNet model files for MSIX sample
- Remove unpackaged profile from launch settings for WindowsML sample
- Add SqueezeNet model files for MSIX sample - Remove unpackaged profile from launch settings for WindowsML sample
Nick Eubanks (nieubank)
requested review from
adrastogi and
Manodasan Wignarajah (manodasanW)
September 23, 2025 16:42
| </ItemGroup> | ||
|
|
||
| <!-- Include SqueezeNet model files in MSIX package --> | ||
| <Target Name="IncludeSqueezeNetFilesInPackage" AfterTargets="CopySqueezeNetModelToOutput" BeforeTargets="_ComputeAppxPackagePayload"> |
There was a problem hiding this comment.
Does Content include not work similar to the above with jpg / png for assets?
Contributor
Author
There was a problem hiding this comment.
If we put these in the Assets folder, it may work, specifying them as Content did not enable them to do into the root directory where the sample code is expecting them though.
adrastogi
approved these changes
Sep 23, 2025
Manodasan Wignarajah (manodasanW)
approved these changes
Sep 23, 2025
adrastogi
pushed a commit
that referenced
this pull request
Sep 23, 2025
adrastogi
added a commit
that referenced
this pull request
Sep 23, 2025
* Improvements to WindowsML sample for MSIX packaging (#530) * Update Resnet C# sample to use correct registration API (#531) Co-authored-by: Aditya Rastogi <adityar@ntdev.microsoft.com> --------- Co-authored-by: Nick Eubanks <nieubank@microsoft.com> Co-authored-by: Aditya Rastogi <adityar@ntdev.microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.