[WCR Sample] Single dotnet run with unpackage selfcontained as example. - #447
Merged
Merged
Conversation
Gordon Lam (yeelam-gordon)
requested review from
Copilot and
Pratik Anand (pratikone)
and removed request for
Pratik Anand (pratikone)
April 18, 2025 10:10
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README example to reflect the updated dotnet run command for running the Windows Copilot Runtime in unpackaged and self-contained mode with WinAppSDK 1.8 experimental 1.
- Renamed the section heading to include self-contained mode.
- Adjusted the command line example to include new parameters for self-contained mode.
Contributor
There was a problem hiding this comment.
Pull Request Overview
A concise update to the README to reflect the new dotnet run command example for self-contained mode in WCR.
- Revised heading and description to indicate support for unpackaged and self-contained modes.
- Updated the dotnet run command to include self-contained mode flags.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README to showcase the new self-contained mode support for WCR in the WinAppSDK 1.8 experimental release. Key changes include:
- Updating the section header to include self-contained mode.
- Revising the run command to include self-contained parameters.
- Updating explanatory text to reflect support for both unpackaged and self-contained apps.
Comments suppressed due to low confidence (1)
Samples/WindowsCopilotRuntime/README.md:48
- The command now includes both '-p:WindowsAppSDKSelfContained=true' and '-p:SelfContained=true'. Please verify that both flags are required and do not lead to any conflicts.
dotnet run -p:Configuration=Debug -p:Platform=ARM64 -p:WindowsPackageType=None -p:WindowsAppSDKSelfContained=true -p:SelfContained=true
Pratik Anand (pratikone)
approved these changes
Apr 22, 2025
Manodasan Wignarajah (manodasanW)
pushed a commit
that referenced
this pull request
May 19, 2025
…e. (#447) * Combine unpackage and selfcontain as single dotnet run command as example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Given WCR already support Self-contained in WinAppSDK 1.8 experimental 1, updated the dotnet run command example in readme accordingly.
As the result, people can run this sample directly WITHOUT need to install WinAppSDK 1.8 experiment 1 on their machine.
Target Release
Please specify which release this PR should align with WCR WinAppSDK 1.8 experimental 1, which is what the project is referencing now.