Skip to content

Add Directory.Build.props - #378

Merged
Bob Pulliam (bpulliam) merged 1 commit into
release/experimentalfrom
user/bpulliam/props
Aug 28, 2024
Merged

Add Directory.Build.props#378
Bob Pulliam (bpulliam) merged 1 commit into
release/experimentalfrom
user/bpulliam/props

Conversation

@bpulliam

Copy link
Copy Markdown
Contributor

Description

Add a Directory.Build.props to enable common configuration of all samples.

Target Release

Checklist

  • Samples build and run using the Visual Studio versions listed in the Windows development docs.
  • Samples build and run on all supported platforms (x64, x86, ARM64) and configurations (Debug, Release).
  • Samples set the minimum supported OS version to Windows 10 version 1809.
  • Samples build clean with no warnings or errors.
  • [For new samples]: Samples have completed the sample guidelines checklist and follow standardization/naming guidelines.
  • If I am onboarding a new feature, then I must have correctly setup a new CI pipeline for my feature with the correct triggers and path filters laid out in the "Onboarding Samples CI Pipeline for new feature" section in samples-guidelines.md.
  • I have commented on my PR /azp run SamplesCI-<FeatureName> to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.
@bpulliam Bob Pulliam (bpulliam) changed the title Add app WinUIDesktopAppWithIsland (#357) Aug 28, 2024
@JesseCol

Copy link
Copy Markdown
Collaborator

We have some existing Directory.Build.props in subdirectories. Can we have those chain to this one?

https://learn.microsoft.com/en-us/visualstudio/msbuild/customize-by-directory?view=vs-2022#use-case-multi-level-merging

@bpulliam

Copy link
Copy Markdown
Contributor Author

We can, but I already have a green build in Agg. Let's get this existing in and that one can come in later.

@bpulliam
Bob Pulliam (bpulliam) merged commit 805e71c into release/experimental Aug 28, 2024
@bpulliam
Bob Pulliam (bpulliam) deleted the user/bpulliam/props branch August 28, 2024 16:07
alexlamtest pushed a commit that referenced this pull request Nov 9, 2024
alexlamtest added a commit that referenced this pull request Nov 9, 2024
* Add Directory.Build.props (#378)

* [Build] Ensure chaining of directory.build.props files reaches the new central one for Sample apps (#380)

---------

Co-authored-by: Bob Pulliam <bpulliam@gmail.com>
alexlamtest pushed a commit that referenced this pull request Dec 5, 2024
alexlamtest added a commit that referenced this pull request Dec 5, 2024
* Add Directory.Build.props (#378)

* [Build] Ensure chaining of directory.build.props files reaches the new central one for Sample apps (#380)

---------

Co-authored-by: Bob Pulliam <bpulliam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants