Add Directory.Build.props - #378
Merged
Merged
Conversation
Bob Pulliam (bpulliam)
requested review from
Jesse Collins (JesseCol),
alexlamtest and
Mike Crider (codendone)
August 28, 2024 15:34
Collaborator
|
We have some existing Directory.Build.props in subdirectories. Can we have those chain to this one? |
Contributor
Author
|
We can, but I already have a green build in Agg. Let's get this existing in and that one can come in later. |
Jesse Collins (JesseCol)
approved these changes
Aug 28, 2024
alexlamtest
pushed a commit
that referenced
this pull request
Nov 9, 2024
7 tasks
alexlamtest
added a commit
that referenced
this pull request
Nov 9, 2024
alexlamtest
pushed a commit
that referenced
this pull request
Dec 5, 2024
7 tasks
alexlamtest
added a commit
that referenced
this pull request
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a Directory.Build.props to enable common configuration of all samples.
Target Release
Checklist
/azp run SamplesCI-<FeatureName>to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.