User/jstall/build2024on16p2 - #375
Merged
Merged
Conversation
* Initial checkin * Add SceneNode Helmet * Add readme.md * Organize usings and remove Reunion nuget feed * Add Lottie
…ental (#360) * Create Directory.Build.targets * Update nuget.config * Update Directory.Build.targets * Update Directory.Build.targets * Update WinUIComponentCs.csproj * Update CsUnpackagedAppNotifications.csproj * add CoreWebView2 nuget reference to all samples for WinAppSDK 1.6 compat * Merge additional CoreWebView2 nuget reference fixes (#359) * Fix up .vcxproj apps for WinUI Custom CWV2SDK support * Patch all remaining .vcxproj for 1.6 CWV2 work --------- Co-authored-by: DmitriyKomin <dkomin@microsoft.com> --------- Co-authored-by: Manodasan Wignarajah <mawign@microsoft.com> Co-authored-by: Scott Jones <sjones@microsoft.com> Co-authored-by: DmitriyKomin <dkomin@microsoft.com>
* Port DrawingIsland samples into WASDK 1.6 Exp 2 This ports the user/jeffstall/drawingisland Samples shown at Build 2024 into the release/experimental branch for WASDK 1.6 Exp 2. * Delete DrawingIsland.cpp Remove older sample.
* Update nuget.config * Update nuget.config
Collaborator
|
Talking with Alex, sounds like this may be difficult to validate it works in the pipelines before merging to main. I'm ok with merging to main now, and cleaning up any problems that may hit in the pipelines. |
Jesse Collins (JesseCol)
approved these changes
Aug 26, 2024
| <Import Project="$(NugetPackageDirectory)\Microsoft.Windows.ImplementationLibrary.1.0.220914.1\build\native\Microsoft.Windows.ImplementationLibrary.targets" Condition="Exists('$(NugetPackageDirectory)\Microsoft.Windows.ImplementationLibrary.1.0.220914.1\build\native\Microsoft.Windows.ImplementationLibrary.targets')" /> | ||
| <Import Project="$(NugetPackageDirectory)\Microsoft.Windows.SDK.BuildTools.10.0.22621.756\build\Microsoft.Windows.SDK.BuildTools.targets" Condition="Exists('$(NugetPackageDirectory)\Microsoft.Windows.SDK.BuildTools.10.0.22621.756\build\Microsoft.Windows.SDK.BuildTools.targets')" /> | ||
| <Import Project="$(NugetPackageDirectory)\Microsoft.WindowsAppSDK.1.5.240227000\build\native\Microsoft.WindowsAppSDK.targets" Condition="Exists('$(NugetPackageDirectory)\Microsoft.WindowsAppSDK.1.5.240227000\build\native\Microsoft.WindowsAppSDK.targets')" /> | ||
| <Import Project="$(NugetPackageDirectory)\Microsoft.Web.WebView2.1.0.2646-prerelease\build\native\Microsoft.Web.WebView2.targets" Condition="Exists('$(NugetPackageDirectory)\Microsoft.Web.WebView2.1.0.2646-prerelease\build\native\Microsoft.Web.WebView2.targets')" /> |
Collaborator
There was a problem hiding this comment.
Is it possible to use a stable (not prerelease) version of WebView2?
Jesse Collins (JesseCol)
added a commit
that referenced
this pull request
Aug 29, 2024
This reverts commit 0fd53eb.
Jesse Collins (JesseCol)
added a commit
that referenced
this pull request
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update Build 2024 BRK241 talk demos to use WASDK 1.6 Preview 2:
Target Release
WASDK 1.6 Preview 2.
Checklist