Fix vectorized replace_copy for bool arrays, also test replace - #6381
Merged
Stephan T. Lavavej (StephanTLavavej) merged 11 commits intoJul 28, 2026
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Copilot started reviewing on behalf of
Alex Guteniev (AlexGuteniev)
July 26, 2026 14:22
View session
Alex Guteniev (AlexGuteniev)
marked this pull request as ready for review
July 26, 2026 14:24
This comment was marked as resolved.
This comment was marked as resolved.
Copilot started reviewing on behalf of
Alex Guteniev (AlexGuteniev)
July 26, 2026 14:29
View session
Copilot started reviewing on behalf of
Alex Guteniev (AlexGuteniev)
July 26, 2026 14:37
View session
Stephan T. Lavavej (StephanTLavavej)
requested changes
Jul 26, 2026
github-project-automation
Bot
moved this from Initial Review
to Work In Progress
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
added a commit
to hazzlim/STL
that referenced
this pull request
Jul 26, 2026
Copilot started reviewing on behalf of
Alex Guteniev (AlexGuteniev)
July 26, 2026 18:58
View session
Stephan T. Lavavej (StephanTLavavej)
moved this from Work In Progress
to Initial Review
in STL Code Reviews
Copilot started reviewing on behalf of
Stephan T. Lavavej (StephanTLavavej)
July 26, 2026 21:42
View session
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jul 26, 2026
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Ready To Merge
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Member
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
Stephan T. Lavavej (StephanTLavavej)
merged commit Jul 28, 2026
059ee42
into
microsoft:main
48 checks passed
Member
|
Thanks for fixing and testing this! 🛠️ 🪄 😻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot has discovered a bug in
replacevectorization for 8-bit elements that is being implemented. Stephan T. Lavavej (@StephanTLavavej) observed thatreplace_copyhas already this bug in. This PR fixes the bug.The problem happens when vectorized
replaceis called for bool array and the replacement is an integer that is a non-value representation when converted to bool.Due to
_Could_compare_equal_to_value_typewe don't have the comparand equivalent of this problem.Since there are only two algorithms that need such handling (
replaceandreplace_copy), and only one exact type, I think we should just dispatch it separately.