<regex>: Clean up fullmatch flag handling - #6261
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoApr 29, 2026
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
added
enhancement
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Apr 18, 2026
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Ready To Merge
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Member
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
Stephan T. Lavavej (StephanTLavavej)
merged commit Apr 29, 2026
465d661
into
microsoft:main
49 checks passed
Member
🏴☠️ 🧹 🏳️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR performs some minor cleanups:
_Regex_match1()took a flag_Full, but all call sites passtrue, so we can just remove this argument. (I renamed the function even though it's not necessary, strictly speaking; there will be more changes to its signature.)_Matcher3::_Matchtook an argument_Full_match, but the value is the same for all calls on the same instance. Let's move this argument to the constructor and remove it from_Match2()(rename also not strictly necessary).constto updated function definitions._STD-qualified calls.