Skip to content

Various cleanups - #6256

Merged
Stephan T. Lavavej (StephanTLavavej) merged 8 commits into
microsoft:mainfrom
StephanTLavavej:various-cleanups
Apr 17, 2026
Merged

Various cleanups#6256
Stephan T. Lavavej (StephanTLavavej) merged 8 commits into
microsoft:mainfrom
StephanTLavavej:various-cleanups

Conversation

@StephanTLavavej

Copy link
Copy Markdown
Member
  • Improve comments citing MSDN.
  • Comments: Consistently capitalize ASan (and other minor cleanups).
  • ppltasks.cpp: Add preprocessor comments.
  • pplerror.cpp: Adjust preprocessor logic, no functional change.
  • Avoid multi-assigns in mersenne_twister_engine::seed(), no functional change.
    • This reverses the order in which we initialize/assign the local variable _Prev but that has no effect.
  • ranges::iota can use contiguous_iterator.
  • Improve preprocessor comments for ASan annotations.
  • Avoid multi-definitions.
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
1 pipeline(s) require an authorized user to comment /azp run to run.
@StephanTLavavej

Copy link
Copy Markdown
Member Author

I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Comment thread tests/std/tests/P2093R14_formatted_output/test.cpp
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) moved this from Final Review to Merging in STL Code Reviews Apr 16, 2026
@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 1f8bce9 into microsoft:main Apr 17, 2026
49 checks passed
@github-project-automation github-project-automation Bot moved this from Merging to Done in STL Code Reviews Apr 17, 2026
@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) deleted the various-cleanups branch April 17, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

2 participants