Implement LWG-4511 Inconsistency between the deduction guide of std::mdspan taking (data_handle_type, mapping_type, accessor_type) and the corresponding constructor - #6231
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoApr 17, 2026
Conversation
Co-authored-by: Jakub Mazurkiewicz <mazkuba3@gmail.com>
Stephan T. Lavavej (StephanTLavavej)
added
LWG
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Apr 13, 2026
| static_assert(same_as<decltype(mds), mdspan<bool, extents<int, 2, 2>, TrackingLayout<>, VectorBoolAccessor>>); | ||
| } | ||
|
|
||
| if !consteval { // typename AccessorType::data_handle_type, const MappingType&, const AccessorType& |
There was a problem hiding this comment.
No change requested: This is the first use of if consteval as far as I'm aware, but it's fine in C++23-only code.
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Ready To Merge
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Member
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
Stephan T. Lavavej (StephanTLavavej)
merged commit Apr 17, 2026
aa8d71d
into
microsoft:main
49 checks passed
Member
4️⃣ 5️⃣ 1️⃣ 1️⃣ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6219.