<regex>: Avoid generating _N_nop nodes when parsing assertions - #6199
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoApr 17, 2026
Conversation
Stephan T. Lavavej (StephanTLavavej)
added
performance
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Apr 4, 2026
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Ready To Merge
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Member
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
Stephan T. Lavavej (StephanTLavavej)
merged commit Apr 17, 2026
e60708d
into
microsoft:main
49 checks passed
Member
🐈 🐈⬛ 😻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #5962.
This removes the generation of
_N_nopnodes when parsing assertions. Such a node was generated so that the NFA branch for the body of the assertion could be attached to it. But we can just as well initially generate the branch for the assertion body as the successor of the_N_assertnode, as though the body wouldn't be part of the assertion but follow it, and then relink the branch into the correct position as the child of the_N_assertnode.This appears to have been the last (and maybe always the only) case where the parser generated
_N_nopnodes. But we must keep around the code in the matcher that handles this node type until vNext.Benchmark
Small but consistent improvement for assertions: