Skip to content

Use _WIN64 test where applicable - #6183

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
AlexGuteniev:win64
Mar 27, 2026
Merged

Use _WIN64 test where applicable#6183
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
AlexGuteniev:win64

Conversation

@AlexGuteniev

Copy link
Copy Markdown
Contributor

Follow up to #6160

Use _WIN64 test instead of _M_IX86 test where it looks consistent with previous usages:

  • In bit functions, where it tests for native 64-bit bit intrinsics availability
  • In atomics, where it tests for native 64-bit interlocked intrinsics availability

Keep _M_IX86 when it means something else.
There are places where it means calling conventions or name mangling, for example.

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) moved this from Initial Review to Ready To Merge in STL Code Reviews Mar 25, 2026
@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required.

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) moved this from Ready To Merge to Merging in STL Code Reviews Mar 26, 2026
@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 11ada44 into microsoft:main Mar 27, 2026
49 checks passed
@github-project-automation github-project-automation Bot moved this from Merging to Done in STL Code Reviews Mar 27, 2026
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for making the codebase more consistent! 📈 😻 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

2 participants