Fix CodeQL warnings after _wsetlocale() changes - #6179
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoMar 27, 2026
Conversation
Stephan T. Lavavej (StephanTLavavej)
added
the
enhancement
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
March 23, 2026 21:24
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Final Review
in STL Code Reviews
Mahmoud Saleh (MahmoudGSaleh)
approved these changes
Mar 23, 2026
Stephan T. Lavavej (StephanTLavavej)
moved this from Final Review
to Ready To Merge
in STL Code Reviews
Member
Author
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
merged commit Mar 27, 2026
49a58a1
into
microsoft:main
49 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes internal VSO-2845667 and VSO-2845668.
CodeQL is emitting SM02986: cpp/incorrect-string-type-conversion, saying "Conversion from
char *to__wchar_t *. Use of invalid string can lead to undefined behavior." for<xlocinfo>and "Conversion fromconst char *toconst __wchar_t *. Use of invalid string can lead to undefined behavior." forlocale0.cpp.These warnings are desirable, we're just doing something that's intentionally sketchy-looking but correct. Accordingly, I'm adding suppression comments, citing #5781 where these changes were introduced.
CodeQL appears to warn only when
reinterpret_casting fromchar*towchar_t*, not the reverse (possibly because casts tochar*are very common). Just in case, I am additionally adding the suppression to thereinterpret_cast<char*>where we actually store the wide string.