Optimize integer to_chars with division by 100 - #6007
Merged
Stephan T. Lavavej (StephanTLavavej) merged 12 commits intoMar 4, 2026
Merged
Optimize integer to_chars with division by 100#6007Stephan T. Lavavej (StephanTLavavej) merged 12 commits into
to_chars with division by 100#6007Stephan T. Lavavej (StephanTLavavej) merged 12 commits into
Conversation
# Conflicts: # stl/inc/xutility
Stephan T. Lavavej (StephanTLavavej)
requested changes
Mar 3, 2026
github-project-automation
Bot
moved this from Initial Review
to Work In Progress
in STL Code Reviews
Alex Guteniev (AlexGuteniev)
requested a review
from Stephan T. Lavavej (StephanTLavavej)
March 3, 2026 16:04
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Mar 3, 2026
Member
|
Thanks! 😻 After fixing the bug that was invalidating the benchmark, my 5950X results are good:
|
Stephan T. Lavavej (StephanTLavavej)
moved this from Work In Progress
to Ready To Merge
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Member
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
Stephan T. Lavavej (StephanTLavavej)
merged commit Mar 4, 2026
1877461
into
microsoft:main
49 checks passed
Member
|
Thanks for improving my favorite function! 🎉 🚀 🐈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep repeating that part, as inlining fails