filesystem.cpp: __std_fs_write_reparse_data_buffer() should use the size of the buffer, not buffer pointer - #5976
Closed
AZero13 (AZero13) wants to merge 1 commit into
Closed
filesystem.cpp: __std_fs_write_reparse_data_buffer() should use the size of the buffer, not buffer pointer#5976AZero13 (AZero13) wants to merge 1 commit into
filesystem.cpp: __std_fs_write_reparse_data_buffer() should use the size of the buffer, not buffer pointer#5976AZero13 (AZero13) wants to merge 1 commit into
Conversation
Member
|
This certainly appears to be a bug, after looking into how |
Stephan T. Lavavej (StephanTLavavej)
added
bug
Stephan T. Lavavej (StephanTLavavej)
changed the title
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Work In Progress
in STL Code Reviews
Member
|
We don't think this fix is correct, |
|
After a quick search on the internet, it seems that
#define REPARSE_DATA_BUFFER_HEADER_SIZE UFIELD_OFFSET(REPARSE_DATA_BUFFER, GenericReparseBuffer)Its value is 8. |
Member
|
Superseded by #6064, thanks everyone. |
github-project-automation
Bot
moved this from Work In Progress
to Done
in STL Code Reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.