Skip to content

Add Neon implementation of minmax #5963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 12 commits into from
Jan 15, 2026
Merged

Add Neon implementation of minmax #5963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0fdf9e2
Add Neon implementation of minmax
hazzlim Dec 11, 2025
38165c3
Use strict types and conversions for all Neon in _Sorting namespace
hazzlim Jan 7, 2026
1571345
Add _Sign_correction
hazzlim Jan 7, 2026
9f0039d
inspect `_Traits::_Has_unsigned_cmp`
hazzlim Jan 7, 2026
578dbaa
Add const qualifier to _Mask parameters
hazzlim Jan 7, 2026
ed516ff
Add comment regarding preventing autovec of scalar tail
hazzlim Jan 7, 2026
9bcd65f
Chain together ARM64 and ARM64EC preprocessor conditionals.
hazzlim Jan 7, 2026
87b0fa8
Refactor _Is_min_max_optimization_safe/_Is_min_max_value_optimization…
hazzlim Jan 7, 2026
b68b39c
Fix x64 build
hazzlim Jan 9, 2026
e73b2fc
Wrap max/min of unrolled accumulators in if constexpr blocks
hazzlim Jan 9, 2026
69f80eb
Make vector tail loop condition more explicit (and fix shadowing)
hazzlim Jan 9, 2026
35b1ab4
Add newlines.
StephanTLavavej Jan 13, 2026
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stl/inc/xutility
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ _STL_DISABLE_CLANG_WARNINGS
#define _VECTORIZED_FIND_LAST_OF _VECTORIZED_FOR_X64_X86
#define _VECTORIZED_INCLUDES _VECTORIZED_FOR_X64_X86
#define _VECTORIZED_IS_SORTED_UNTIL _VECTORIZED_FOR_X64_X86
#define _VECTORIZED_MINMAX _VECTORIZED_FOR_X64_X86
#define _VECTORIZED_MINMAX _VECTORIZED_FOR_X64_X86_ARM64
#define _VECTORIZED_MINMAX_ELEMENT _VECTORIZED_FOR_X64_X86_ARM64
#define _VECTORIZED_MISMATCH _VECTORIZED_FOR_X64_X86
#define _VECTORIZED_REMOVE _VECTORIZED_FOR_X64_X86
Expand Down Expand Up @@ -7302,7 +7302,7 @@ constexpr bool _Is_min_max_value_optimization_safe = // Activate the vector algo
#ifndef _M_FP_FAST
!is_floating_point_v<_Elem> &&
#endif // ^^^ !defined(_M_FP_FAST) ^^^
_Is_min_max_optimization_safe<_Iter, _Pr>;
_Is_min_max_iterators_safe<_Iter> && _Is_predicate_less<_Iter, _Pr>;

template <class _FwdIt, class _Pr>
constexpr _FwdIt _Max_element_unchecked(_FwdIt _First, _FwdIt _Last, _Pr _Pred) { // find largest element
Expand Down
Loading