Implement LWG-4272: For rank == 0, layout_stride is atypically convertible - #5900
Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits intoNov 27, 2025
Merged
Conversation
Jakub Mazurkiewicz (JMazurkiewicz)
requested a review
from a team
as a code owner
November 21, 2025 22:49
Stephan T. Lavavej (StephanTLavavej)
added
LWG
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Nov 23, 2025
| requires is_constructible_v<extents_type, _OtherExtents> | ||
| constexpr explicit(extents_type::rank() > 0) mapping(const layout_stride::mapping<_OtherExtents>& _Other) noexcept | ||
| constexpr explicit(!(extents_type::rank() == 0 && is_convertible_v<_OtherExtents, extents_type>) ) | ||
| mapping(const layout_stride::mapping<_OtherExtents>& _Other) noexcept |
There was a problem hiding this comment.
No change requested: layout_left::mapping and layout_right::mapping vary in their noexcept // strengthened vs. noexcept, but this matches the Standard's varying noexcept, despite the fact that they both have preconditions. I think this should be an LWG issue (but am too lazybusy to report it).
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Ready To Merge
in STL Code Reviews
Member
|
I've updated #3807 as you recommended! |
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Stephan T. Lavavej (StephanTLavavej)
merged commit Nov 27, 2025
1e6d927
into
microsoft:main
44 checks passed
Member
0️⃣ 🏃 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially implement #5856.
I believe we should close #5856 and mention LWG-4272 in #3807.