Skip to content

<algorithm>: Rework internal buffers for stable sorting algorithms - #5807

Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
microsoft:mainfrom
frederick-vs-ja:refactor-optimistic-temporary-buffer
Oct 29, 2025
Merged

<algorithm>: Rework internal buffers for stable sorting algorithms#5807
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
microsoft:mainfrom
frederick-vs-ja:refactor-optimistic-temporary-buffer

Conversation

@frederick-vs-ja

Copy link
Copy Markdown
Contributor

By changing the _Aligned_storage_t array to an aligned unsigned char array. Affected buffers are renamed to avoid potential mix-and-mismatch.

Fixes #5800.

@frederick-vs-ja
A. Jiang (frederick-vs-ja) force-pushed the refactor-optimistic-temporary-buffer branch from e135130 to b74d3b3 Compare October 25, 2025 10:32
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added the bug Something isn't working label Oct 25, 2025
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) moved this from Initial Review to Ready To Merge in STL Code Reviews Oct 25, 2025
@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) moved this from Ready To Merge to Merging in STL Code Reviews Oct 28, 2025
@StephanTLavavej

Copy link
Copy Markdown
Member

/clr:pure was failing the alignment assertion at runtime, presumably because it isn't actually aligning anything. Guess how much I care about /clr:pure? I've pushed a commit to disable this new test for it.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 755f6c9 into microsoft:main Oct 29, 2025
39 checks passed
@github-project-automation github-project-automation Bot moved this from Merging to Done in STL Code Reviews Oct 29, 2025
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for fixing this bug and reducing our dependencies on this deprecated type trait! 😻 🎉 📉

@frederick-vs-ja
A. Jiang (frederick-vs-ja) deleted the refactor-optimistic-temporary-buffer branch October 29, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

2 participants