vector_algorithms.cpp: fix incorrect activation of bitmap find-meow-of algorithms - #5758
Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits intoOct 10, 2025
Conversation
Alex Guteniev (AlexGuteniev)
force-pushed
the
magic-it-happens
branch
from
October 4, 2025 05:35
db34833 to
5453927
Compare
Alcaro
reviewed
Oct 4, 2025
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Oct 8, 2025
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Ready To Merge
in STL Code Reviews
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
merged commit Oct 10, 2025
5f63382
into
microsoft:main
39 checks passed
Member
|
Thanks for investigating and fixing this regression so quickly! 🛠️ 🕵️ 🪄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5757
The activation function
_Can_fit_256_bits_sseskipped past some elements, which caused incorrect activation of bitmap algorithm, which then addressed array out-of-bounds.