Skip to content

Restore implicitly converting cases in the test for P0466R5 - #5737

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
frederick-vs-ja:refix_bad_ptm_substitution
Sep 25, 2025
Merged

Restore implicitly converting cases in the test for P0466R5#5737
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
frederick-vs-ja:refix_bad_ptm_substitution

Conversation

@frederick-vs-ja

Copy link
Copy Markdown
Contributor

Instead of removing the problematic test cases (#5730), this PR reintroduces and fixes them by fully specifying template arguments to enable intentional implicit conversions.

Corresponding fix for the example in the standard is submitted in cplusplus/draft#8245.

Instead of removing the problematic test cases, this PR reintroduces and
fixes them by fully specifying template arguments to enable intentional
implicit conversions.
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) moved this from Initial Review to Ready To Merge in STL Code Reviews Sep 23, 2025
@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) moved this from Ready To Merge to Merging in STL Code Reviews Sep 25, 2025
@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 358868a into microsoft:main Sep 25, 2025
39 checks passed
@github-project-automation github-project-automation Bot moved this from Merging to Done in STL Code Reviews Sep 25, 2025
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for preserving this test coverage and getting the Standard fixed up! 😻 🛠️ 📜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Related to test code

2 participants