Skip to content

Improve existing vector<bool> benchmarks - #5732

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
AlexGuteniev:before-dinosaurs
Sep 25, 2025
Merged

Improve existing vector<bool> benchmarks#5732
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
AlexGuteniev:before-dinosaurs

Conversation

@AlexGuteniev

Copy link
Copy Markdown
Contributor

The following minor changes:

  • Extract createRandomVector, use the version that doesn't use static, and rename it to random_bool_vector for consitency.
  • Use optimization barriers, and avoid const on source to make them effective.
  • Remove one stray newline.
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) moved this from Initial Review to Ready To Merge in STL Code Reviews Sep 25, 2025
@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) moved this from Ready To Merge to Merging in STL Code Reviews Sep 25, 2025
@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit af895f2 into microsoft:main Sep 25, 2025
39 checks passed
@github-project-automation github-project-automation Bot moved this from Merging to Done in STL Code Reviews Sep 25, 2025
@StephanTLavavej

Copy link
Copy Markdown
Member

🧹 ⏱️ 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Must go faster test Related to test code

2 participants