<vector>: Silence static analysis warning C26450 - #5707
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoSep 3, 2025
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
added
the
enhancement
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
September 3, 2025 05:13
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Final Review
in STL Code Reviews
Mahmoud Saleh (MahmoudGSaleh)
approved these changes
Sep 3, 2025
Mahmoud Saleh (MahmoudGSaleh)
left a comment
Mahmoud Saleh (MahmoudGSaleh)
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for taking care of the warning.
Stephan T. Lavavej (StephanTLavavej)
merged commit Sep 3, 2025
8722a5e
into
microsoft:main
39 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain cases (not found by our test coverage, but by the MSVC codebase's own usage),
/analyzeemits a false positive warning about integer overflow, when we've carefully guarded against integer overflow. Carson Radtke (@carsonRadtke) has filed VSO-2565428 "C26450 FP in STL/vector" to track fixing this in/analyze. Until then, we should push-disable-pop the warning around the affected code.Followup to #5550 and #5566. So it's time for a quote:
- Ra (Abstract Weapon) by qntm