Build the benchmark with clang-cl only on x64 - #5704
Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits intoSep 10, 2025
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
added
performance
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Aug 29, 2025
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Ready To Merge
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed |
Stephan T. Lavavej (StephanTLavavej)
merged commit Sep 10, 2025
b2976dc
into
microsoft:main
39 checks passed
Member
|
Thanks for improving CI reliability! 🛡️ 🦾 💯 |
Stephan T. Lavavej (StephanTLavavej)
added
infrastructure
Alex Guteniev (AlexGuteniev)
deleted the
randomly-fix-random-build-issue
branch
September 10, 2025 15:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's infrequent but not very rara access violation when linking with the benchmark using clang-cl on x86.
Apparently x64 works always.
Let's keep only x64 built on CI. It might worth giving another try when clang-cl is updated to the next major.
Note that this change does not prevent building x86 benchmark with clang-cl locally, only makes it possible for this configuration to bit rot.