CMake build: Add /CETCOMPAT for x64, /guard:MEOW for various architectures - #5652
Merged
Stephan T. Lavavej (StephanTLavavej) merged 5 commits intoSep 10, 2025
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
added
bug
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Work In Progress
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
changed the title
Inspected both GitHub and MSVC build logs.
Stephan T. Lavavej (StephanTLavavej)
changed the title
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Sep 4, 2025
Member
|
My apologies for how long it took to get around to this. I audited the MSBuild machinery and extracted what I believe are the most important missing options. I verified both the GitHub and MSVC-internal builds, checking that the expected options are present or not for all architectures. There are probably a few more missing flags but I believe this is a strict improvement. |
Stephan T. Lavavej (StephanTLavavej)
moved this from Work In Progress
to Ready To Merge
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed |
Stephan T. Lavavej (StephanTLavavej)
merged commit Sep 10, 2025
10b879e
into
microsoft:main
39 checks passed
Member
|
Thanks for noticing and fixing this very subtle build divergence! 🦅 👁️ 😻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5646. Fixes #5651.