validate.cpp: report error lines - #5559
Merged
Stephan T. Lavavej (StephanTLavavej) merged 21 commits intoJun 14, 2025
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Stephan T. Lavavej (StephanTLavavej)
added
enhancement
1 is the "default" / "don't care" value used below.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 6, 2025
Member
|
Thanks! 😻 This should make it easier than ever for contributors to find and fix their validation problems. I pushed a bunch of nitpicks and one enhancement: using the new strategy for disallowed characters. This helps ADO present all errors on the first page, instead of hiding the rest behind more details. |
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Ready To Merge
in STL Code Reviews
Closed
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 6, 2025
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for making it easier than ever to conform to the repo's formatting requirements! 😻 📈 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2349