<regex>: Fix word bounds \b and \B when applied to the empty string - #5375
Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits intoApr 10, 2025
Conversation
Stephan T. Lavavej (StephanTLavavej)
added
bug
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Apr 1, 2025
Member
|
Thanks for the fix, test coverage, and clear writeup with citations! I pushed a trivial change to use raw string literals. |
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Ready To Merge
in STL Code Reviews
Closed
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Resolved adjacent-add conflict in |
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Apr 10, 2025
Member
🐝 🪲 🐞 |
Julian Müller (muellerj2)
deleted the
regex-fix-word-bounds-on-empty-string
branch
April 13, 2025 13:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5371.
The ECMAScript standard effectively states that
\bmatches a positioniin the string iffIsWordChar(i-1) xor IsWordChar(i)is true. It also defines that for positionsi = -1andi = length(input),IsWordChar(i)always returnsfalse. Thus,\bdoes not match anything in the empty string.Since
\bdoes not match the empty string, the flagsmatch_not_bowandmatch_not_eowdon't matter in this case.