<xutility>: Adjust inheritance detection for enable_view - #5369
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoApr 10, 2025
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
added
bug
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Mar 31, 2025
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Ready To Merge
in STL Code Reviews
Closed
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
🐞 🛠️ 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per [range.view]/6, a
view_interfaceisn't a base class of itself, soenable_viewshould reportfalse. Also, current implementation strategy handlesconstbut notvolatile, IIUC cv-qualifiers should be consistent handled.Coverage for (
const)volatiletypes are added.The original issue was reported as LLVM-132577, and the PR fixing it (LLVM-132582) was recently accepted for libc++.
Drive-by: Change the implement strategy of
operator<=>foroptionalto be more consistent with the Standardese ([optional.syn]), as the old_Derived_from_specialization_ofdoesn't seem reusable.