Initially use [[msvc::no_unique_address]] for some C++23 components - #4960
Merged
Stephan T. Lavavej (StephanTLavavej) merged 16 commits intoMar 25, 2025
Merged
Conversation
- `in_value_result` - `out_value_result` - `mdspan` - `join_with_view`'s sentinel - `enumerate_view`'s iterator and sentinel - `chunk_view`'s iterator - `slide_view`'s sentinel
This comment was marked as resolved.
This comment was marked as resolved.
Casey Carter (CaseyCarter)
added
performance
This comment was marked as resolved.
This comment was marked as resolved.
Stephan T. Lavavej (StephanTLavavej)
removed
the
decision needed
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Oct 20, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Closed
This comment was marked as resolved.
This comment was marked as resolved.
Stephan T. Lavavej (StephanTLavavej)
added
the
blocked
This comment was marked as resolved.
This comment was marked as resolved.
Stephan T. Lavavej (StephanTLavavej)
marked this pull request as draft
October 26, 2024 14:56
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
A. Jiang (frederick-vs-ja)
marked this pull request as ready for review
February 20, 2025 11:03
This comment was marked as resolved.
This comment was marked as resolved.
Stephan T. Lavavej (StephanTLavavej)
removed
the
blocked
Stephan T. Lavavej (StephanTLavavej)
moved this from Blocked
to Work In Progress
in STL Code Reviews
This comment was marked as resolved.
This comment was marked as resolved.
Stephan T. Lavavej (StephanTLavavej)
moved this from Work In Progress
to Initial Review
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Mar 3, 2025
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Ready To Merge
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Stephan T. Lavavej (StephanTLavavej)
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Mar 21, 2025
Member
|
Thanks for implementing these long-awaited space optimizations! 🛰️ 🚀 🪐 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #1364.
Applied:
in_value_resultout_value_resultmdspanjoin_with_view's sentinelenumerate_view's iterator and sentinelchunk_view's iteratorslide_view's sentinelelements_ofNot yet applied due to DevCom-10588147 and possibly related issues.
view_interfaceas their empty bases.iterator_category.chunk_by_view's iterator, possibly because the non-potentially-overlapping member is listed first.Not yet applied because it's unclear to me how to reuse padding bytes in
tuplezip-familyNot yet applied due to another unclear reasons
expectedOther changes:
/* [[no_unique_address]] */for_Index_typeofrepeat_view's iterator because the_Index_typenever has padding bytes<mdspan>: More EBO #3847 to a separated test fileattempt to test NVCC for these changesfailed and reverted.