Fixed MRTK3 so it can compile in Unity 2022 with no automated code changes. - #11668
Merged
Adam Mollis (AMollis) merged 4 commits intoJul 3, 2023
Merged
Conversation
Adam Mollis (AMollis)
requested review from
Marlena Klein (marlenaklein-msft) and
Scott Haynie (shaynie)
as code owners
July 3, 2023 20:33
Scott Haynie (shaynie)
approved these changes
Jul 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixing MRTK3 so it can compile in Unity 2022 with no automated code changes. Changes include:
Handles.FreeMoveHandlechanges in Unity 2022rotationhandles in theVectorHandlefunction, since the new version ofHandles.FreeMoveHandledoesn't support rotation. I think this ok. Nothing is actually using theVectorHandlefunction,ProjectAuditorfrom test project, since the latest version is not compiling in latest Unity 2022.Changes