Update UI to display different instructions for different error codes - #1137
Merged
Conversation
Contributor
Author
|
Also ran |
ttanatb
requested review from
kocdemir,
purvisa-at-google-com,
sonakshisaxena1 and
yalcinmelihyasin
July 14, 2022 11:59
| withLayoutData( | ||
| createGroup(this, ""), withSpans(new GridData(SWT.FILL, SWT.TOP, true, false), 3, 1)); | ||
| Text errText = | ||
| withLayoutData( |
Contributor
There was a problem hiding this comment.
Nit: Is this line break after assignment a java style?
Contributor
Author
There was a problem hiding this comment.
According to the Google Java style guide:
When a line is broken at an assignment operator the break typically comes after the symbol, but either way is acceptable.
I think there's nothing prohibiting withLayoutData to be on the same line as Text errText = but I ran the java formatter and this is what it produced
yalcinmelihyasin
approved these changes
Jul 26, 2022
sonakshisaxena1
pushed a commit
to sonakshisaxena1/agi
that referenced
this pull request
Aug 2, 2022
…google#1137) Add Validation UI to handle different error codes
rosasco-wk
pushed a commit
to rosasco-wk/agi
that referenced
this pull request
Sep 3, 2022
…google#1137) Add Validation UI to handle different error codes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed to validate trace file:
Consistently fails to validate trace file (after 3 tries):
Precondition error:
Other kinds of error
Validation Passes:
