web/elements: render selected value in ak-search-select regardless of page - #25610
Open
GirlBossRush wants to merge 1 commit into
Open
web/elements: render selected value in ak-search-select regardless of page#25610GirlBossRush wants to merge 1 commit into
GirlBossRush wants to merge 1 commit into
Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-171be88e1672d70004ebad76d18c8b5d09854f3a
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-171be88e1672d70004ebad76d18c8b5d09854f3aAfterwards, run the upgrade commands from the latest release notes. |
… page Move the 'keep the current selection visible' responsibility into the component. getGroupedItems now includes selectedObject as an option when the fetched page doesn't contain it (skipped while searching), so a paginated selection renders instead of falling back to the placeholder. Call sites pass the object they already have via .selectedObject and drop the bespoke fetchObjects merges: PolicyBindingForm (policy/group/user), StageBindingForm (stage), and TokenForm (user).
GirlBossRush
force-pushed
the
web/search-select-self-render-selected
branch
from
August 31, 2026 21:10
171be88 to
8ed1749
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generalizes the fix from #25609 (now merged) by moving it into the component, so new call sites don't have to remember to work around it.
ak-search-selectonly ever rendered options from the fetched API page, so a selected object that sorted onto a later page of a paginated list had no matching option and the field fell back to its placeholder. #25609 worked around this by merging the current value into eachfetchObjectsresult — one copy per call site, easy to forget.Instead,
getGroupedItemsnow includes the component's ownselectedObjectas an option when the fetched page doesn't already contain it (skipped while the user is actively searching, so a stale selection doesn't pin itself atop filtered results). Call sites just pass the object they already have via.selectedObjectand drop the bespoke merges:PolicyBindingForm— policy, group, user (removes the merges added in web: show pre-selected value in paginated search-selects #25609)StageBindingForm— stage (removes the merge added in web: show pre-selected value in paginated search-selects #25609)TokenForm— user (removes the older pre-existing merge)ak-provider-search-inputis intentionally left as-is: it has only a pk (no embedded object) and already fetches the single provider by id, which is the correct approach for that case.Relates to #25406.