fix(auth, android): getIdToken() IllegalStateException crash fix - #11362
Merged
Conversation
Valansch
reviewed
Jul 24, 2023
| password: testPassword, | ||
| ); | ||
|
|
||
| await FirebaseAuth.instance.signOut(); |
There was a problem hiding this comment.
Is there any reason why you are first signing in and then out to reproduce this? Are you not getting this issue if you don't do signIn&signOut first?
Because I can reproduce the issue using any credential, no signout required.
Member
Author
There was a problem hiding this comment.
Correct - I've updated the test.
Contributor
|
Note that as part of this PR, |
Lyokone
approved these changes
Jul 25, 2023
kalyujniy
approved these changes
Jul 25, 2023
dackers86
approved these changes
Jul 25, 2023
kutlayhanli
pushed a commit
to kutlayhanli/flutterfire
that referenced
this pull request
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
see title.
Related Issues
fixes #11297
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?